Feat/camera integration #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 4, 2022 22:06
Created an camera fragment. On create this fragment asks for camera permissions. The logic has also been implemented to this fragment that the fragment can easily be called from other parts of the app.
|
Somehow the ui tests only fail on cirrus but all pass locally. Something of CameraPreviewTest messes with cirrus |
gaetschwartz
approved these changes
Apr 6, 2022
|
Yes, I agree that more tests are needed. I think it's better to do more tests after the whole ml pipeline is integrated. Otherwise, some of the implemented tests can't be used. |
bhvrgav
reviewed
Apr 7, 2022
fix: remove idea folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.