Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Webpack 5 #1939

Closed
Tiggles opened this issue Oct 22, 2020 · 5 comments
Closed

Upgrade to Webpack 5 #1939

Tiggles opened this issue Oct 22, 2020 · 5 comments
Assignees
@Tiggles
Labels
Core: Frontend enhancement

Comments

@Tiggles
Copy link
Contributor

Tiggles commented Oct 22, 2020 •
edited
Loading

Some preliminary work has been done, but some issues remain:

  • Polyfills for some NodeJS modules are stripped out from Webpack 5, meaning we will have to supply them ourselves (more than just npm i <package> apparently). Solved by adding resolve.fallback matching.
  • Importing JSON files content (e.g. import {PRODUCT_NAME} from "../../site.config.json) is being deprecated and should be changed. Currently, I don't know if this is possible without the use of "allowSyntheticDefaultImports": true, in our tsconfig-file.
@Tiggles
Copy link
Contributor Author

Tiggles commented Oct 26, 2020 •
edited
Loading

  • process is deprecated. This is used to check environment. Seems solvable using env and setting it.

@Tiggles
Copy link
Contributor Author

Tiggles commented Oct 28, 2020

Also stops building from working.

Tiggles added a commit that referenced this issue Nov 9, 2020
@Tiggles
Do some #1939 related changes
c900dd7
Tiggles added a commit that referenced this issue Nov 10, 2020
@Tiggles
Some groundwork for #1939 and improve config files
b79e3be
Tiggles added a commit that referenced this issue Nov 10, 2020
@Tiggles
Remove references to process in webpack configs #1939
0e3048f
@Tiggles
Copy link
Contributor Author

Tiggles commented Nov 12, 2020

Blocked by React-Markdown, can be solved by polyfilling:
vfile/vfile#38

@Tiggles
Copy link
Contributor Author

Tiggles commented Mar 1, 2021

Solved by installing process pack and shimming the package.

@Tiggles Tiggles closed this as completed in f4eade6 Mar 1, 2021
@Tiggles Tiggles self-assigned this Mar 2, 2021
@Tiggles Tiggles reopened this Mar 2, 2021
@Tiggles
Copy link
Contributor Author

Tiggles commented Mar 2, 2021

Building issues

@Tiggles Tiggles closed this as completed in 16d2572 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tiggles Tiggles

Labels
Core: Frontend enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tiggles