Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance remove the bitmap copy during encoding #19

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Performance remove the bitmap copy during encoding #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e646515
Remove the unused copy for rgba bitmap buffer during encoding
dreampiggy Apr 16, 2020
d19abc8
Update readme about the thumbnail encoding
dreampiggy Apr 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,15 +185,41 @@ let image = SDImageHEIFCoder.shared.decodedImage(with: data, options: [.decodeTh
```objectivec
UIImage *image;
NSData *imageData = [image sd_imageDataAsFormat:SDImageFormatHEIF];
// Encode Quality
NSData *lossyData = [[SDImageHEIFCoder sharedCoder] encodedDataWithImage:image format:SDImageFormatHEIF options:@{SDImageCoderEncodeCompressionQuality : @(0.1)}]; // [0, 1] compression quality
NSData *limitedData = [[SDImageHEIFCoder sharedCoder] encodedDataWithImage:image format:SDImageFormatHEIF options:@{SDImageCoderEncodeMaxFileSize : @(1024 * 10)}]; // v0.8.0 feature, limit output file size <= 10KB
```

+ Swift

```swift
let image;
let imageData = image.sd_imageData(as: .HEIF)
// Encode Quality
let lossyData = SDImageHEIFCoder.shared.encodedData(with: image, format: .heif, options: [.encodeCompressionQuality: 0.1]) // [0, 1] compression quality
let limitedData = SDImageHEIFCoder.shared.encodedData(with: image, format: .heif, options: [.encodeMaxFileSize: 1024 * 10]) // v0.8.0 feature, limit output file size <= 10KB
```

### Thumbnail Encoding

+ Objective-C

```objective-c
// HEIF image thumbnail encoding
UIImage *image;
NSData *thumbnailData = [[SDImageHEIFCoder sharedCoder] encodedDataWithImage:image format:SDImageFormatHEIF options:@{SDImageCoderEncodeMaxPixelSize : @(CGSizeMake(200, 200)}]; // v0.8.0 feature, encoding max pixel size
```

+ Swift

```swift
// HEIF image thumbnail encoding
let image: UIImage
let thumbnailData = SDImageHEIFCoder.shared.encodedData(with: image, format: .heif, options: [.encodeMaxPixelSize: CGSize(width: 200, height: 200)]) // v0.8.0 feature, encoding max pixel size
```

See more documentation in [SDWebImage Wiki - Coders](https://github.com/SDWebImage/SDWebImage/wiki/Advanced-Usage#custom-coder-420)

## Screenshot

<img src="https://raw.githubusercontent.com/SDWebImage/SDWebImageHEIFCoder/master/Example/Screenshot/HEIFDemo.png" width="300" />
Expand Down
11 changes: 4 additions & 7 deletions SDWebImageHEIFCoder/Classes/SDImageHEIFCoder.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,13 +451,7 @@ - (nullable NSData *)sd_encodedHEIFDataWithImage:(nonnull UIImage *)image qualit
// fill the plane
int stride;
uint8_t *planar = heif_image_get_plane(img, channel, &stride);
size_t bytes_per_pixel = (bitsPerPixel + 7) / 8;
for (int y = 0 ; y < height ; y++) {
memcpy(planar + y * stride, rgba + y * stride, width * bytes_per_pixel);
}

// free the rgba buffer
free(rgba);
planar = rgba;

// check thumbnail encoding
int ctuSize = 64;
Expand All @@ -469,6 +463,7 @@ - (nullable NSData *)sd_encodedHEIFDataWithImage:(nonnull UIImage *)image qualit
heif_image *thumbnail_img;
error = heif_image_scale_image(img, &thumbnail_img, (int)scaledSize.width, (int)scaledSize.height, NULL);
if (error.code != heif_error_Ok) {
free(rgba);
heif_image_release(img);
heif_encoder_release(encoder);
heif_context_free(ctx);
Expand All @@ -482,6 +477,7 @@ - (nullable NSData *)sd_encodedHEIFDataWithImage:(nonnull UIImage *)image qualit
heif_image_handle *handle;
error = heif_context_encode_image(ctx, img, encoder, NULL, &handle);
if (error.code != heif_error_Ok) {
free(rgba);
heif_image_release(img);
heif_encoder_release(encoder);
heif_context_free(ctx);
Expand All @@ -499,6 +495,7 @@ - (nullable NSData *)sd_encodedHEIFDataWithImage:(nonnull UIImage *)image qualit
error = heif_context_write(ctx, &writer, (__bridge void *)(mutableData));

// clean up
free(rgba);
heif_image_release(img);
heif_encoder_release(encoder);
heif_image_handle_release(handle);
Expand Down