Refactor/init type hints #3038
Refactor/init type hints #3038
Conversation
| steps: | ||
| - | ||
| uses: actions/checkout@v2 | ||
| - | ||
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: '3.7' | ||
| python-version: '3.9' |
There was a problem hiding this comment.
SEED is on 3.9!
| ignore_missing_imports = True | ||
|
|
||
| [mypy-seed.*.migrations.*] | ||
| ignore_errors = True |
There was a problem hiding this comment.
Ignoring migration files for now b/c they raise type issues that aren't helpful
| @@ -150,7 +152,7 @@ def evaluate(self, parameters=None): | |||
| parameters = {} | |||
|
|
|||
| self._transformer.set_params(parameters) | |||
| return self._parser.parse(self._expression) | |||
| return self._parser.parse(self._expression) # type: ignore[return-value] | |||
There was a problem hiding this comment.
Great example of types not working well sometimes. mypy is unable to infer that the Tree has a decorator which evaluates the tree (in this case into a float)
| @@ -31,6 +31,44 @@ To run flake locally call: | |||
|
|
|||
| tox -e flake8 | |||
|
|
|||
| Python Type Hints | |||
There was a problem hiding this comment.
Looking for feedback on this. Specifically:
- If you don't use VSCode, what do you use? we should check if there's a suitable extension for it
- Is the usage of types clear and sufficient?
There was a problem hiding this comment.
- I use VSCode
- I think I'm following. Typing is not mandatory but preferred going forward. If I run into issues I can always use
# type: ignore
There was a problem hiding this comment.
I use Sublime and it looks like there's a plugin already that ties mypy in: https://github.com/fredcallaway/SublimeLinter-contrib-mypy
| CI currently runs static type checking on the codebase using `mypy <http://mypy-lang.org/>`_. For | ||
| your own IDE, we recommend the following extensions: | ||
|
|
||
| - VSCode: `Pylance <https://marketplace.visualstudio.com/items?itemName=ms-python.vscode-pylance>`_ (uses Microsoft's Pyright type checking) |
| import sys | ||
| if sys.version_info[:3] == (2, 7, 3): | ||
| import threading | ||
| threading._DummyThread._Thread__stop = lambda x: 42 |
There was a problem hiding this comment.
yikes, this was in there for a long time!!!
| @@ -11,10 +11,7 @@ | |||
| import math | |||
| import tempfile | |||
|
|
|||
| try: | |||
There was a problem hiding this comment.
cleanup cleanup everybody cleanup
Any background context you want to provide?
See linked issues
What's this PR do?
How should this be manually tested?
N/A, but definitely look through the edited
derived_columns.pyfileWhat are the relevant tickets?
#3034
Screenshots (if appropriate)
Example of an untyped func with hints (VSCode)
Example using type hints for derived_columns stuff
