Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call bison with -Wno-other #294

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Commits on Oct 23, 2024

  1. Call bison with -Wno-other

    Bison in 3.8.2 added new warnings to catch m4 strings accidentally included in the generated code output.  It had the unfortunate side effect of flagging grammars that include "m4_foo" style strings as identifiers in their grammar (which we do).  Based on the thread, it looks like a fix was implemented on the Bison side, but as of three years later, no release has been made.  Bison seems to possibly have maintainer inactivity: akimd/bison#103.
    
    Since a fix for the false positive is not forthcoming, disable the
    warning.  Unfortunately, I don't think a more granular disablement is
    available, but IMO false positive warnings are worse than false
    negatives.
    dburgener committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2ad684c View commit details
    Browse the repository at this point in the history