Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated GLSL.cs #217

Merged
merged 1 commit into from Jun 2, 2022
Merged

Updated GLSL.cs #217

merged 1 commit into from Jun 2, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 2, 2022 •
edited by ghost
Loading

Mentioned in #213: CSFML specifies defines sfBool as int which is a 4-byte long integer. Until decided, I have marked the fields to be marshalled as Bool which seems to fix the issue. This will probably be to be fixed later. but it works for now on 64x OS's

eXpl0it3r
eXpl0it3r approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@eXpl0it3r eXpl0it3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Have you tested this to work as expected?

@ghost
Copy link
Author

ghost commented Jun 2, 2022

Looks good!

Have you tested this to work as expected?

You bet! I wasn't able to find any direct issues.

@eXpl0it3r eXpl0it3r added the Bug label Jun 2, 2022
@eXpl0it3r eXpl0it3r merged commit 80eaf1f into SFML:master Jun 2, 2022
@eXpl0it3r
Copy link
Member

Thanks for this fix 🥳

@eXpl0it3r eXpl0it3r mentioned this pull request Jun 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eXpl0it3r