-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't install SFML when installing the project #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it makes sense, as it otherwise makes the install target kind of unusable
320218d
to
deb8c03
Compare
didn't realise the decision had been made not to support installation in the template a few months ago (before changes were requested here) which makes this kind of redundant (edit: suppose not entirely redundant as it makes it generally more efficient) Seems silly imo to not support it, it's one of the most common questions new users ask about and would be useful for many people with minimal effort |
3f08bb1
to
cba78b9
Compare
Raising the CMake requirement beyond CMake 3.22 means that Ubuntu 22 users no longer have a seamless experience using this template. There are a number of ways to remedy this in decreasing order of what I would personally recommend.
|
Just a case of adding the subdirectory with
EXCLUDE_FROM_ALL
.In cmake 3.28 you can pass this property directly to fetchcontent which is nicer but presume we're a way off using that versionAs discussed, we are happy to move to 3.28 as part of thisAlso had to change the fetch content name to lowercase, which is required for the source/binary dir variables to work correctly and is good practice anyway.
closes #6
edit: bonus side-effect of users not having to build sfml modules they aren't using