Add GitHub Actions Workflow & Basic Window Support #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for opening this pull request. This might be helpful for others. |
|
Its currently not planned to include this PR, however I will leave it open, so others can benefit from your work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this pull requests adds a GitHub Actions workflow that compiles the library on
The PR also modifies the CMake code slightly to add support for Windows (Visual Studio). The updates are basically a result of a question of a co-worker, if I could help him to compile this library on Windows.
I hope the code updates do not break anything and might be helpful to others. Please be advised that I did not test the updates (yet) – I never used a laser scanner (neither from SICK nor from any other company). If I should change anything in the pull request, please let me know below. Thank you.