-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
concept?labelcontains and concept?anylabel endpoints don't limit to skos:Concepts #14
Comments
Thanks for the question - it's an interesting point. The selector at the moment doesn't constrain to skos:Concept but given that the endpoint is @dr-shorthair - what do you think if we change this to include constraining this API call to |
Thus, while Since this API call is |
(We currently encounter this issue in practice, due to the way PoolParty adds metadata for concept schemes. Sample URL: http://vocabs.ands.org.au/repository/api/lda/abares/australian-land-use-and-management-classification/version-8/concept?labelcontains=Australian This should return no results, but it returns the ConceptScheme instead. Another example of the same thing: http://vocabs.ands.org.au/repository/api/lda/ga/protocol-type/v1-2/concept?labelcontains=Protocol ) |
The issue as I see it is:
I have no problem with a solution that includes preserving the current behaviour of these endpoints, as long as they're not called |
Yes - I agree - if the API call (i.e. the endpoint URL) contains What I'm suggesting is to also add endpoints with |
Something like #15 ? |
Something like that. Do you have a reason for doing it in a different way from the earlier version (see original comment with the query from commit df181c6, but noting that that query doesn't include matches against rdfs:labels). At first glance, your version looks up Concepts three times instead of just once. But maybe the query optimizer notices that. (I have no idea if it does hoisting of that sort.) |
Which comment? (I don't see any - is it embedded in one of the TTL files?) |
By "original comment" I meant "the first comment in this GitHub issue", i.e., #14 (comment) |
Ah - your concern is not so much I'm not sure that the one you quote makes a whole lot of sense (can't see how these combos quite work) but indeed, |
The fourth in a series of a commits to include upstream changes to SISSVoc. Fix the /concept?anylabel and /concept?labelcontains endpoints so that they only return SKOS concepts, not arbitrary resources. Add new /resource?anylabel and /resource?labelcontains endpoints that do what the above endpoints _used_ to do. See upstream issue SISS/SISSVoc#14 and pull request SISS/SISSVoc#15 . RVA-298
The
concept?labelcontains
endpoint doesn't limit its results to resources that areskos:Concept
s.The results include resources of any type, if they have an
rdfs:label
.Commit df181c6 removed a lot of vocabulary-specific configs that have a selector something like this:
But the remaining generic config
SISSvoc3-ELDAConfig-template.ttl
defines theconcept?labelcontains
endpoint with this selector:How come the selector doesn't include
?item a skos:Concept
?The same question applies also to the
concept?anylabel
endpoint.The text was updated successfully, but these errors were encountered: