Remove overly complicated background video measurement management for…

… comScore (#649)

.swiftpm/xcode/xcshareddata/xcschemes/Analytics.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1510"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

.swiftpm/xcode/xcshareddata/xcschemes/Circumspect.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1510"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

.swiftpm/xcode/xcshareddata/xcschemes/Core.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1510"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

.swiftpm/xcode/xcshareddata/xcschemes/CoreBusiness.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1510"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

.swiftpm/xcode/xcshareddata/xcschemes/Pillarbox-Package-NoDebug.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1510"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

.swiftpm/xcode/xcshareddata/xcschemes/Pillarbox-Package.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1510"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

.swiftpm/xcode/xcshareddata/xcschemes/Player.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1510"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

Demo/Packages/youtube-identifier/.swiftpm/xcode/xcshareddata/xcschemes/YouTubeIdentifier-Package.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1510"
    version = "1.7">
    <BuildAction
       parallelizeBuildables = "YES"

Demo/Pillarbox-demo.xcodeproj/project.pbxproj

@@ -505,7 +505,7 @@
 			attributes = {
 				BuildIndependentTargetsInParallel = 1;
 				LastSwiftUpdateCheck = 1400;
-				LastUpgradeCheck = 1500;
+				LastUpgradeCheck = 1510;
 				TargetAttributes = {
 					6F05B8D42887E934005D75E3 = {
 						CreatedOnToolsVersion = 14.0;
@@ -630,6 +630,7 @@
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
 				ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONS = YES;
+				CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
 				CLANG_ANALYZER_NONNULL = YES;
 				CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
 				CLANG_CXX_LANGUAGE_STANDARD = "gnu++20";
@@ -691,6 +692,7 @@
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
 				ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONS = YES;
+				CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
 				CLANG_ANALYZER_NONNULL = YES;
 				CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
 				CLANG_CXX_LANGUAGE_STANDARD = "gnu++20";
@@ -803,6 +805,7 @@
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
 				ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONS = YES;
+				CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
 				CLANG_ANALYZER_NONNULL = YES;
 				CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
 				CLANG_CXX_LANGUAGE_STANDARD = "gnu++20";

Demo/Pillarbox-demo.xcodeproj/xcshareddata/xcschemes/Pillarbox-demo.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1510"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

Sources/Analytics/ComScore/ComScoreTracker.swift

@@ -16,24 +16,15 @@ import UIKit
 public final class ComScoreTracker: PlayerItemTracker {
     private var streamingAnalytics = ComScoreStreamingAnalytics()
     private var metadata: [String: String] = [:]
-    private var properties: PlayerProperties?
     private weak var player: Player?
 
-    private var applicationState: ApplicationState = .foreground {
-        didSet {
-            guard let properties else { return }
-            updateProperties(with: properties)
-        }
-    }
-
     public init(configuration: Void) {}
 
     public func enable(for player: Player) {
         self.player = player
         streamingAnalytics.createPlaybackSession()
         streamingAnalytics.setMediaPlayerName("Pillarbox")
         streamingAnalytics.setMediaPlayerVersion(Player.version)
-        registerApplicationStateNotifications()
     }
 
     public func updateMetadata(with metadata: [String: String]) {
@@ -50,22 +41,11 @@ public final class ComScoreTracker: PlayerItemTracker {
     }
 
     public func updateProperties(with properties: PlayerProperties) {
-        self.properties = properties
-        notify(with: properties)
-    }
-
-    // swiftlint:disable:next cyclomatic_complexity
-    private func notify(with properties: PlayerProperties) {
         guard !metadata.isEmpty, let player else { return }
 
         AnalyticsListener.capture(streamingAnalytics.configuration())
         streamingAnalytics.setProperties(for: properties, time: player.time, streamType: properties.streamType)
 
-        guard applicationState == .foreground else {
-            streamingAnalytics.notifyEvent(for: .paused, at: properties.rate)
-            return
-        }
-
         switch (properties.isSeeking, properties.isBuffering) {
         case (true, true):
             streamingAnalytics.notifySeekStart()
@@ -82,45 +62,7 @@ public final class ComScoreTracker: PlayerItemTracker {
     }
 
     public func disable() {
-        unregisterApplicationStateNotifications()
         streamingAnalytics = ComScoreStreamingAnalytics()
         player = nil
     }
 }
-
-private extension ComScoreTracker {
-    enum ApplicationState {
-        case foreground
-        case background
-    }
-
-    func registerApplicationStateNotifications() {
-        NotificationCenter.default.addObserver(
-            self,
-            selector: #selector(didEnterBackground(_:)),
-            name: UIApplication.didEnterBackgroundNotification,
-            object: nil
-        )
-        NotificationCenter.default.addObserver(
-            self,
-            selector: #selector(didBecomeActive(_:)),
-            name: UIApplication.didBecomeActiveNotification,
-            object: nil
-        )
-    }
-
-    func unregisterApplicationStateNotifications() {
-        NotificationCenter.default.removeObserver(self, name: UIApplication.didEnterBackgroundNotification, object: nil)
-        NotificationCenter.default.removeObserver(self, name: UIApplication.didBecomeActiveNotification, object: nil)
-    }
-
-    @objc
-    private func didEnterBackground(_ notification: Notification) {
-        applicationState = .background
-    }
-
-    @objc
-    private func didBecomeActive(_ notification: Notification) {
-        applicationState = .foreground
-    }
-}

docs/GETTING_STARTED.md

@@ -366,6 +366,10 @@ When `SystemVideoView` is presented inline, though, its close button is replaced
 
 Switching between a `VideoView` and a `SystemVideoView` for the content currently being played in Picture in Picture is not supported and leads to undefined behavior.
 
+## Background video playback
+
+`Player` can be enabled for background video playback using `audiovisualBackgroundPlaybackPolicy`. For SRG SSR content, though, your application must not implement background video playback to avoid issues with comScore measurements. Please implement proper Picture in Picture support instead.
+
 ## Have fun
 
 This is only a glimpse of what can be achieved with Pillarbox. Though the feature set is still limited you should already be able to implement pretty interesting playback experiences. Please have a look at the documentation (which can be built with Xcode _Product_ > _Build Documentation_) and check the demo and its various examples to better understand what is possible.