Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate packages #574

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Translate packages #574

merged 1 commit into from
Sep 19, 2023

Conversation

defagos
Copy link
Member

@defagos defagos commented Sep 19, 2023

Description

This PR adds localization catalogs to packages requiring localization.

Changes made

  • Add localization catalogs to Player and CoreBusiness packages.
  • Enable demo localization (but do not localize the demo itself).

Some localizations are missing, see #573 for automation or manual request for translation.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • The playground has been updated (if relevant).

@defagos defagos linked an issue Sep 19, 2023 that may be closed by this pull request
Translations #318
Closed
2 tasks
@waliid waliid added this pull request to the merge queue Sep 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2023
@defagos defagos added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit 71d83f8 Sep 19, 2023
@defagos defagos deleted the 318-translations branch September 19, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waliid waliid waliid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translations
2 participants
@defagos @waliid