Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix media selection issues when altering current selection programmatically #600

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Fix media selection issues when altering current selection programmatically #600

merged 2 commits into from
Oct 13, 2023

Conversation

defagos
Copy link
Member

@defagos defagos commented Oct 12, 2023

Description

This PR fixes the related bug, restoring our initial API and mitigating iOS 17 performance issues with a simple cache implemented by QueuePlayer.

Changes made

  • Restore media selection binding API.
  • Add media selection criteria cache to QueuePlayer.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • The playground has been updated (if relevant).

@defagos defagos linked an issue Oct 12, 2023 that may be closed by this pull request
Media selection is not updated in menu when a change is applied programmatically #598
Closed
1 task
@defagos defagos disabled auto-merge October 12, 2023 18:42
@waliid waliid added this pull request to the merge queue Oct 13, 2023
@waliid waliid added follow up Don't forget to check if it's still relevant and removed follow up Don't forget to check if it's still relevant labels Oct 13, 2023
Merged via the queue into main with commit ec4ec42 Oct 13, 2023
6 checks passed
@waliid waliid deleted the 598-media-selection-is-not-updated-in-menu-when-a-change-is-applied-programmatically branch October 13, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waliid waliid waliid approved these changes

Assignees
No one assigned
Labels
follow up Don't forget to check if it's still relevant
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Media selection is not updated in menu when a change is applied programmatically
2 participants
@defagos @waliid