Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the deferred seek #632

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Correct the deferred seek #632

merged 3 commits into from
Nov 17, 2023

Conversation

waliid
Copy link
Member

@waliid waliid commented Nov 16, 2023

Description

Self-explanatory.

Changes made

  • Avoid pausing playback when seeking in deferred mode.
  • Avoid hiding playback controls when the user interacts with the slider in deferred mode.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • The playground has been updated (if relevant).

@waliid waliid self-assigned this Nov 16, 2023
@waliid waliid added this pull request to the merge queue Nov 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 17, 2023
@waliid waliid added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit 293aa1a Nov 17, 2023
6 checks passed
@waliid waliid deleted the fix-deferred-seek branch November 17, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants