Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve setting support #638

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Improve setting support #638

merged 3 commits into from
Nov 20, 2023

Conversation

defagos
Copy link
Member

@defagos defagos commented Nov 20, 2023

Description

Following a proposal made in #636 here is a variant which does not make the configuration mutable while still providing mutability for the audiovisual background policy.

Changes made

  • Make audiovisualBackgroundPlaybackPolicy a computed property instead of an immutable player configuration setting.
  • Remove external playback and audiovisual background policy from global app settings. External playback is now always available with our custom player and unavailable in some limited demos, which means we still can observe all behaviors in the demo app.
  • Add audiovisual policy setting to the opt-in demo. Its layout has slightly been improved in the process (use of a List).

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • The playground has been updated (if relevant).

@defagos defagos added this pull request to the merge queue Nov 20, 2023
@defagos defagos self-assigned this Nov 20, 2023
@defagos defagos added the enhancement New feature or request label Nov 20, 2023
Merged via the queue into main with commit 3f1669a Nov 20, 2023
6 checks passed
@defagos defagos deleted the simpler-configuration branch November 20, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants