Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UIKit-oriented APIs #642

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

defagos
Copy link
Member

@defagos defagos commented Nov 21, 2023

Description

This PR removes some APIs initially exposed for UIKit but which are not required anyway as a player should be implenented in SwiftUI, then wrapped into UIKit code if required.

Changes made

  • Hide PictureInPicture.restoreFromInAppPictureInPicture().
  • Hide PictureInPicture. enableInAppPictureInPictureWithCleanup(perform:).
  • Update documentation to remove references to these APIs.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • The playground has been updated (if relevant).

@defagos defagos linked an issue Nov 21, 2023 that may be closed by this pull request
7 tasks
@waliid waliid added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit b69a4e3 Nov 21, 2023
6 checks passed
@waliid waliid deleted the 615-ensure-the-api-can-be-used-in-uikit-apps branch November 21, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure the API can be used in UIKit apps
2 participants