Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve player item tracker API and stream type transition support #647

Conversation

defagos
Copy link
Member

@defagos defagos commented Nov 23, 2023

Description

This PR brings two improvements:

Changes made

  • Update PlayerItemTracker protocol.
  • Update comScore and Commanders Act implementations to match the improved protocol.
  • Update comScore and Commanders Act implementations to remove the stream type inputs.
  • Update tests accordingly.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • The playground has been updated (if relevant).

@defagos defagos linked an issue Nov 23, 2023 that may be closed by this pull request
1 task
@waliid waliid added this pull request to the merge queue Nov 24, 2023
Merged via the queue into main with commit 2118483 Nov 24, 2023
6 checks passed
@waliid waliid deleted the 607-revisit-commanders-act-implementation-to-support-stream-type-transitions branch November 24, 2023 08:17
@defagos defagos linked an issue Nov 24, 2023 that may be closed by this pull request
5 tasks
@defagos defagos mentioned this pull request Dec 5, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit Commanders Act implementation to support stream type transitions Improve tracker API contract
2 participants