Imports UI changes from comp/2024. #268
Conversation
| @@ -128,6 +135,43 @@ export class AppState { | |||
| }); | |||
| } | |||
|
|
|||
| setIgnoreFieldSide(ignore_side: number) { | |||
| const state = this; // fix dumb javascript things | |||
There was a problem hiding this comment.
this line seems to be unused
some other functions also have this same unused line
the functions that do use it do so for valid reasons (i.e. used to pass a reference to a function declaration, since the interpretation of "this" will be different when the function is called)
| } | ||
|
|
||
| let pos = PIXI.Point; | ||
| pos = event.global; |
There was a problem hiding this comment.
Suggest merge with line 139 to reduce confusion
| }, | ||
| rightClickDrag: function(event) { | ||
| const viewport = this.pixi.stage.getChildAt(0); | ||
| const ball_pos = viewport.getChildByName("ball").getChildAt(0).position; |
There was a problem hiding this comment.
Seems to be unused
Is this deliberate?
|
|
||
| this.state.sendSimulatorControlPacket(simulator_command); | ||
| }, | ||
| rightClickDrag: function(event) { |
There was a problem hiding this comment.
This function seems like it moves the ball to the cursor, and if dragged, draws the ball velocity vector, but it does not seem to update the state
| endX: [-.12, -.1, .1, .12, .05], | ||
| endY: [-.03, .07, .07, -.03, -.09], | ||
| textX: [-.12, -.12, .12, .12, 0], | ||
| textY: [-.12, .14, .14, -.12, -.13] | ||
| } | ||
|
|
||
| // TODO: Figure out what order the motor numbers use |
| @@ -171,6 +171,7 @@ export default { | |||
| if (general) errString = errString + "G"; | |||
| if (hall) errString = errString + "H"; | |||
| if (encoder) errString = errString + "E"; | |||
| errString = String(i); | |||
There was a problem hiding this comment.
Is this line intentional?
It seems like the error info will be stripped and replaced with the current index
| @@ -7,6 +7,7 @@ import { Ball } from "@/ball" | |||
| import { Field, FieldDimensions, FieldSidedInfo } from "@/field" | |||
| import { AIState } from "@/AI" | |||
| import { Play } from "@/play" | |||
| import { exportDefaultSpecifier } from "@babel/types" | |||
| this.services["setIgnoreFieldSide"].callService(request, | ||
| function(result) { | ||
| if(!result.success) { | ||
| console.log("Failed to set ignore side: ", result.reason); |
There was a problem hiding this comment.
Should probably be console.error or console.warn
Same with the other instances of logging unsuccessful requests
No description provided.