ipa role: adding sshpubkey parameter to users

[danlavu]

No description provided.

[danlavu]

I'm still getting comfortable working with multiple commits and amending changes to previous commits. I have an extra commit I was trying to squash.

[danlavu]

tests that use this enhancement SSSD/sssd#7608

[spoore1]

Overall looks good. Just a few small things to check on.

[spoore1]

LGTM

[pbrezina]

This won't work if you call keygen multiple times.

You can:

• return (pubkey, privatekey) pair instead of self
• or return a new object e.g. SSHKey that will hold the information

[danlavu]

I never intended it to be called keygen multiple times without changing the file name... like
https://github.com/SSSD/sssd/blob/99073123c4727a005d7f72b1a784c4474eb1231d/src/tests/system/tests/test_ipa.py#L193

I'm a little confused; I do have an object, SSHKeysUtils, that should be created each time, that contains the user, path and file. Get returns a tuple of the public and private keys.

[pbrezina]

But SSHKeysUtils is not create multiple times, it is created only once for each test.

If you want it to be created multiple times, then you should do it via @property. It also should not inherit from MultihostUtility, but from object in this case.

@property
def keygen(...) -> SSHKeyUtils:
    return SSHKeyUtils(...)

public_key, private_key = client.tools.keygen.generate()

Or we can leave it as is (single object) but then it should not set an internal state.

[danlavu]

Removed the class inheritance and made keygen a property that calls SSHKeyUtils

[spoore1]

Just a question about the class name.

[pbrezina]

Hi Dan, it looks good, thank you. See nitpicks inside.

[spoore1]

LGTM