Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Remove Fedora 41 and 42 from matrix for sssd-2-9. #7573

Open
wants to merge 2 commits into
base: sssd-2-9
Choose a base branch
from
Open

ci: Remove Fedora 41 and 42 from matrix for sssd-2-9. #7573

wants to merge 2 commits into from

Conversation

jakub-vavra-cz
Copy link
Contributor

The current pending/devel Fedora versions contain sssd-2.10 so it does not make any sense to try install (unsuccessfully) sssd-2.9 on them.

@alexey-tikhonov
Copy link
Member

Please also exclude C10S

@jakub-vavra-cz
Copy link
Contributor Author

Please also exclude C10S

For sssd-2-9 are tests not executed on c10s.
I am not sure where is configuration for the build targets to prevent unwanted builds.
Maybe @pbrezina can clarify how to achieve that.

@alexey-tikhonov
Copy link
Member

For sssd-2-9 are tests not executed on c10s.

Ah, indeed.

@pbrezina
Copy link
Member

pbrezina commented Sep 9, 2024

Please also exclude C10S

For sssd-2-9 are tests not executed on c10s. I am not sure where is configuration for the build targets to prevent unwanted builds. Maybe @pbrezina can clarify how to achieve that.

Please also exclude C10S

For sssd-2-9 are tests not executed on c10s. I am not sure where is configuration for the build targets to prevent unwanted builds. Maybe @pbrezina can clarify how to achieve that.

copr builds are run as pull_request_target, the workflow file is taken from the target branch sources not from the pull request. This should resolve itself when this PR is merged.

@jakub-vavra-cz
Copy link
Contributor Author

Please also exclude C10S

For sssd-2-9 are tests not executed on c10s. I am not sure where is configuration for the build targets to prevent unwanted builds. Maybe @pbrezina can clarify how to achieve that.

Please also exclude C10S

For sssd-2-9 are tests not executed on c10s. I am not sure where is configuration for the build targets to prevent unwanted builds. Maybe @pbrezina can clarify how to achieve that.

copr builds are run as pull_request_target, the workflow file is taken from the target branch sources not from the pull request. This should resolve itself when this PR is merged.

Excluded the versions also from build in .github/workflows/copr_build.yml

@pbrezina
Copy link
Member

Hi, it might be better to hardcode f39 and f40, since those are the last releases that run sssd-2-9 branch. Otherwise we will have to patch this again once f41 gets to stable in a month or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbrezina pbrezina Awaiting requested review from pbrezina

Assignees

@pbrezina pbrezina

Labels
Trivial Waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakub-vavra-cz @alexey-tikhonov @pbrezina