RESOLV: add partial support for new c-ares parser #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-tikhonov
force-pushed
the
cares
branch
4 times, most recently
from
389f1dc
to
ed113e8
Compare
`resolv_gethostbyname_dns_parse()` didn't use `status` and it was always set to `ARES_SUCCESS` anyway.
alexey-tikhonov
force-pushed
the
cares
branch
from
ed113e8
to
b841c4e
Compare
instead of deprecated `ares_parse_a/aaaa/_reply()` This patch doesn't replace `ares_parse_srv_reply()` as benefints are quite questionable. Partially resolves SSSD#7571
In theory new API might be somewhat better. But: 1) it's fairly new: `ares_search_dnsrec()` and `ares_query_dnsrec()` were introduced in c-ares-1.28 while even CentOS Stream 10 has c-ares-1.25, so SSSD would need to support (fallback) old API anyway. 2) SSSD doesn't make heavy use of DNS, so potential performance improvements are really negligible. On the other hand, old API/ABI will be available for a long time: c-ares/c-ares#732 (comment) For those reasons it's not worth the effort to port code to new API right now.
alexey-tikhonov
force-pushed
the
cares
branch
from
b841c4e
to
992366c
Compare
alexey-tikhonov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and suppress other deprecation warnings.
Partially resolves #7571