fixed memory leak due to use popt incorrectly #7601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumit-bose
reviewed
Sep 18, 2024
src/tests/test_ssh_client.c
Outdated
| @@ -25,6 +25,9 @@ | |||
| #error "The path to the ssh authorizedkeys helper is not defined" | |||
| #endif /* SSH_CLIENT_DIR */ | |||
|
|
|||
| #define GOTO_END(code) {return_code = code;\ | |||
| goto end;} | |||
|
|
|||
There was a problem hiding this comment.
Hi,
thank you for the fix. I would prefer if you can drop this macro and just have the two lines in all the needed places in the code. In general we try to avoid such error handling macros.
bye,
Sumit
There was a problem hiding this comment.
ok, thank you for review.i will fix it.
xuraoqing
force-pushed
the
master
branch
2 times, most recently
from
5e9e6d8
to
2f27cb4
Compare
Signed-off-by: xuraoqing <[email protected]>
sumit-bose
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7589