Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: adding gpo customer test scenario to use the ldap attribute name #7621

Closed
wants to merge 1 commit into from

Conversation

danlavu
Copy link

@danlavu danlavu commented Sep 26, 2024

No description provided.

Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick on assert message.

src/tests/system/tests/test_gpo.py Show resolved Hide resolved
Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ignore previous comment about assert message.

@alexey-tikhonov
Copy link
Member

tests/test_gpo.py::test_gpo__ldap_user_name_attribute_mapping[ssh] (samba) FAILED [ 82%]
tests/test_gpo.py::test_gpo__ldap_user_name_attribute_mapping[su] (samba) FAILED [ 82%]

@danlavu danlavu force-pushed the tests-gpo-name-attribute branch 2 times, most recently from 53216c0 to 2900936 Compare November 4, 2024 23:00
@danlavu
Copy link
Author

danlavu commented Nov 5, 2024

Samba topology needs to be dropped from the test case, because the name attribute is not populated. It will take a small-ish patch in the framework to get it working. Let's get this merged and moving, we'll worry about the samba stuff later.

Local testing AD passes against sssd-client-2.10.0-1.fc41.x86_64

============================= test session starts ==============================
collecting ... 

Selected tests will use the following hosts:
  client: client.test
  ad: dc.ad.test
  nfs: nfs.test

collected 639 items / 637 deselected / 2 selected

tests/test_gpo.py::test_gpo__ldap_user_name_attribute_mapping[ssh] (ad) 
tests/test_gpo.py::test_gpo__ldap_user_name_attribute_mapping[su] (ad) 

====================== 2 passed, 637 deselected in 44.10s ======================
PASSED [ 50%]PASSED [100%]
Process finished with exit code 0

@alexey-tikhonov
Copy link
Member

Samba topology needs to be dropped from the test case, because the name attribute is not populated. It will take a small-ish patch in the framework to get it working.

I'd say: let's fix framework.
But your call, @thalman

@danlavu danlavu force-pushed the tests-gpo-name-attribute branch 2 times, most recently from fc05e88 to e599b96 Compare November 5, 2024 15:00
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks.

@danlavu
Copy link
Author

danlavu commented Nov 6, 2024

The failure is not related to the patch.

@alexey-tikhonov
Copy link
Member

Pushed PR: #7621

  • master
    • 3054970 - tests: adding gpo customer test scenario to use the ldap attribute name
  • sssd-2-10
    • be90cc6 - tests: adding gpo customer test scenario to use the ldap attribute name
  • sssd-2-9
    • 2df6ff9 - tests: adding gpo customer test scenario to use the ldap attribute name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants