Port to Webpack #1096
Closed
Port to Webpack #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
force-pushed
the
webpack
branch
2 times, most recently
from
c8de27e
to
fff5dba
Compare
This was referenced Mar 3, 2019
Closed
Merged
This was referenced Sep 23, 2019
Merged
|
Closing in favour of #1137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I did not have time to finish this this weekend either, I have decided to push it here as is for now.
It is mostly working, with the exception of serviceworker – we need some reliable webpack plug-in for generating the list of files the service worker should cache and also for invalidating the worker.
I also want to generate index.html so that we do not have to care about it in PHP. That will require API for obtaining config values.