Render sources in navigation client-side #1064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the future, we can replace this with virtual-dom-based templates (e.g Vue.js); for now, this should not be much worse than the current solution. |
jtojnar
force-pushed
the
client-side-templates
branch
from
d98fd12
to
cac0392
Compare
Use EJS to render them
jtojnar
force-pushed
the
client-side-templates
branch
from
cac0392
to
69e0d59
Compare
|
Is this PR still in progress? or we can merge it now? |
|
Yeah, this is WIP. I will revisit it after #1096 |
|
Ok, great. |
|
Surpassed by #1184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @niol