Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create python-package.yml #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create python-package.yml #17

wants to merge 1 commit into from

Conversation

LalitNM
Copy link
Member

@LalitNM LalitNM commented Nov 27, 2020

@abhijeetmanhas this addresses #13, please have a look.

@abhijeetmanhas
Copy link
Member

seems like we need to add doctest rst as a dev dependency, that's why tests are failing.

@LalitNM
Copy link
Member Author

LalitNM commented Nov 27, 2020

Hmm, looks like we need to fix some linting warnings like
./exohunter/__init__.py:3:1: F401 'os' imported but unused ./exohunter/preprocess.py:1:1: F401 'numpy as np' imported but unused as well.

@LalitNM
Copy link
Member Author

LalitNM commented Nov 28, 2020

I came across this. Looks like we have to change accordingly.

https://pypi.org/project/py-package-template/ seems a better alternative.

@LalitNM
Copy link
Member Author

LalitNM commented Nov 29, 2020

@gajrajgchouhan looks like we have a different way to set requirements in this project. See the code below

requires = ["setuptools",
"setuptools_scm",
"wheel"]

@gajrajgchouhan
Copy link
Member

well, I think the requirements are to be setup here in cfg

Exoplanet-Hunt/setup.cfg

Lines 30 to 32 in a20b921

numpy
pandas
scikit-learn

I added the txt file because github action would read them from requirments.txt.
We will have to add any module in setup.cfg too.

Also the pyproject.toml is for installing the project which will read from setup.cfg.

Update python-package.yml

Removed python-3.5 and 3.6 for tests

Removed 'import os'

Removed 'import numpy'

Shifted import at top of file

Create conftest.py

added requirements (after github action)

added astropy to requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants