Fix race condition

STEllAR-GROUP · Sep 9, 2024 · c008395 · c008395
1 parent 5ed299c
commit c008395
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/libs/core/allocator_support/include/hpx/allocator_support/thread_local_caching_allocator.hpp b/libs/core/allocator_support/include/hpx/allocator_support/thread_local_caching_allocator.hpp
@@ -73,20 +73,19 @@ namespace hpx::util {
             pointer allocate(size_type n)
             {
                 pointer p;
-                if (data.empty())
+                std::pair<T*, size_type> pair;
+                if (data.pop(pair))
+                {
+                    p = pair.first;
+                }
+                else
                 {
                     p = traits::allocate(alloc, n);
                     if (p == nullptr)
                     {
                         throw std::bad_alloc();
                     }
                 }
-                else
-                {
-                    std::pair<T*, size_type> pair;
-                    data.pop(pair);
-                    p = pair.first;
-                }
 
                 ++allocated;
                 return p;