Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel relocation test #6367

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

isidorostsa
Copy link
Contributor

In the original test there where two errors:

  1. An atomic variable was fetched in a way that introduced race conditions, skipping the throw portion of the code.
  2. The testing was more strict than necessary, making guesses about the inner workings of partitioner_with_cleanup. Testing that every created object is destroyed in case of an exception is enough to abide by P1144.

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Oct 16, 2023

bors merge

@bors
Copy link

bors bot commented Oct 16, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 3b40531 into STEllAR-GROUP:release-1.10.X Oct 16, 2023
64 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants