Fix warnings from cppcheck static analysis

[escherstair]

No description provided.

[escherstair]

@mgrella, @krt306, @tanujlokpal
can someone have a look to the proposal pull requests?
I can propose other improvements, but I'm not sure if someone on ST side is interested in them.

[tanujlokpal]

Hello @escherstair,

Thanks for your comment.

The checks and initializations in the code are necessary from functionality point of view and should not be changed.

Thanks

[escherstair]

Hi @tanujlokpal
from the "workflow" perspective, nothing is changed in my PR.
They're only fixes suggested by cppcheck (i.e., removing "always true" condition, reduce scope of variable, ...).
They're important because my target is to have as much as possible "zero warnings" in my source code (and in the third party code I use).