Bugfix.confirmed 2 failed after push ok #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but one or more devices are unreachable after the commit call succeeded, devices that are reachable after will still get confirmed even though they should get rolled back. Add extra ping check to fix this.
that the device is still reachable
…empty diff, otherwise wrong message is displayed and job lock is released too early. Add sync event immediately when device is unreachable after commit
calls would not have been read?
…on with commit confirmed mode 1
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #317 +/- ##
===========================================
- Coverage 65.53% 65.43% -0.11%
===========================================
Files 66 66
Lines 7269 7297 +28
===========================================
+ Hits 4764 4775 +11
- Misses 2505 2522 +17
☔ View full report in Codecov by Sentry. |
indy-independence
deleted the
bugfix.confirmed_2_failed_after_push_ok
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.