Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up init_device fails and make it more consistent #358

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

indy-independence
Copy link
Member

Cleanup uplink interfaces on failed init. Cleanup tasks that are supposed to fail for fabric devices in the same way as for access devices. Raise exception on napalm ReplaceConfigException

…osed to fail for fabric devices in the same way as for access devices. Raise exception on napalm ReplaceConfigException
Copy link

sonarcloud bot commented Jul 1, 2024

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.

Project coverage is 64.38%. Comparing base (24f9cda) to head (f8b2556).

Files Patch % Lines
src/cnaas_nms/db/device.py 12.50% 7 Missing ⚠️
src/cnaas_nms/devicehandler/init_device.py 78.94% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #358      +/-   ##
===========================================
- Coverage    64.43%   64.38%   -0.05%     
===========================================
  Files           74       74              
  Lines         8080     8096      +16     
===========================================
+ Hits          5206     5213       +7     
- Misses        2874     2883       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@indy-independence indy-independence merged commit b829813 into develop Jul 2, 2024
8 of 9 checks passed
@indy-independence indy-independence deleted the bugfix.init_handle_replace_exception branch July 2, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant