Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_config_block_regex to extract config section from config #369

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

benedictmulongo
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented Sep 17, 2024

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.36%. Comparing base (7a889df) to head (b21ff9b).
Report is 60 commits behind head on develop.

Files with missing lines Patch % Lines
src/cnaas_nms/tools/jinja_filters.py 30.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #369      +/-   ##
===========================================
- Coverage    64.40%   64.36%   -0.05%     
===========================================
  Files           74       74              
  Lines         8024     8034      +10     
===========================================
+ Hits          5168     5171       +3     
- Misses        2856     2863       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

and mark devices as unsync if there are updates
Only print unsync message if any devices were set to unsync
use it from git.py and git_worktrees.py for when worktree branches get updated
makes the config hash ignore those parts of the config
This can be used together with get_config_section jinja filter to have
sections of the configuration handled by an external tool
running_config for platform/devtype combo, this way we don't need
a new config variable that needs to be synced with templates
comment that make config hash diff, even if the config change was only
in unmanaged parts of the config
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants