Return full path to avoid IsADirectoryError #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting local path, the full path is not returned only the directory (ADAPTER_DATA_DIR) raising an IsADirectoryError when opening the CSP config file Return the full path, directory + filename Add test for get_local_path(filename) method
smarlowucf
approved these changes
Jul 27, 2023
rjschwei
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting local path, the full path is not returned only the directory (ADAPTER_DATA_DIR) raising an IsADirectoryError when opening the CSP config file
Return the full path, directory + filename
Add test for get_local_path(filename) method