Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eager fail for failed registration. #275

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Eager fail for failed registration. #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion usr/share/lib/img_proof/tests/SLES/test_sles_wait_on_registration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,14 @@ def test_sles_wait_on_registration(host):

while time.time() < end:
result = host.run('systemctl is-active guestregister.service')
status = result.stdout.strip()

if result.stdout.strip() == 'inactive':
if status == 'inactive':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider doing this as a guard clause.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It basically is a guard clause though? Just happens inside the loop to prevent code duplication. But the sleep call only happens after the first two clauses.

break
elif status == 'failed':
pytest.fail(
'Registration failed for on-demand instance.'
)
else:
time.sleep(10)
else:
Expand Down