Remove ssh key name requirement from testing. #135
Conversation
IPA will add public key to EC2 instance based on private key file using cloud init script.
smarlowucf
force-pushed
the
testing-ec2-keys
branch
from
162a28a
to
1b1d682
Compare
|
As discussed by mail this looks good to me. There is just a conflict caused by the merge of the simplification patch for the testing service you provided too. Feel free to merge once conflict got resolved |
| @@ -16,3 +16,5 @@ credentials: | |||
| credentials_directory: /var/lib/mash/credentials/ | |||
| obs: | |||
| download_directory: /var/tmp/mash/images | |||
| testing: | |||
| ssh_private_key_file: /etc/mash/testing_key | |||
There was a problem hiding this comment.
We do not want to write the private key to disk if it can be avoided and for mash, since it is generated, based on the discussions this week, it should live in /var/lib/mash/keys/ssh
There was a problem hiding this comment.
The idea is that this is a setting and not something that needs to be auto generated. In setting up a MASH pipeline we setup a ssh private/public key pair and point to the file location. /var/lib/mash/keys/ssh/testing_key could be default but it's nice to give the user options.
This can be discussed in #164 .
smarlowucf
changed the title
smarlowucf
changed the title
IPA will add public key to EC2 instance based on private key file using cloud init script.
Private key file will be provided as a configuration item in MASH config file.