Catch exceptions on password resets creation

It happened sometimes that there was a misconfiguration on the mailer
values and then the passwords controller raised exceptions on password
reset creation. This is bad because the user will face an empty page,
and the logs won't reflect a thing.

With this commit we will catch these exceptions and properly log it.
Furthermore, the user will be redirected to the original page.

Signed-off-by: Miquel Sabaté Solà <[email protected]>

app/controllers/passwords_controller.rb

@@ -17,6 +17,11 @@ def create
     else
       redirect_to new_user_password_path, alert: resource.errors.full_messages, float: true
     end
+  rescue SocketError, Errno::ECONNREFUSED => e
+    Rails.logger.tagged("Mailer") { Rails.logger.info "Exception: #{e.message}" }
+    redirect_to new_user_password_path,
+                alert: "Something went wrong. Check the configuration of Portus",
+                float: true
   end
 
   # Re-implemented from Devise to respond with a proper message on error.

spec/controllers/passwords_controller_spec.rb

@@ -39,6 +39,12 @@
     expect(@user.valid_password?("12341234")).to be false
   end
 
+  it "redirects on socket error and such" do
+    allow(User).to receive(:send_reset_password_instructions) { raise SocketError, "error" }
+    post :create, "user" => { "email" => @user.email }
+    expect(response.status).to eq 302
+  end
+
   describe "LDAP support is enabled" do
     before do
       APP_CONFIG["ldap"] = { "enabled" => true }

spec/lib/portus/registry_notification_spec.rb

@@ -8,7 +8,7 @@
   let(:delete)    { ::Portus::Fixtures::RegistryEvent::DELETE.dup }
   let(:version23) { ::Portus::Fixtures::RegistryEvent::VERSION23.dup }
 
-  it "processes all the relevant events", focus: true do
+  it "processes all the relevant events" do
     evaluated_events = [relevant, delete, version23]
     evaluated_events.each { |e| body["events"] << e }