ceph-volume: fix stderr failure to decode/encode when redirected #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 17, 2019 11:25
Signed-off-by: Alfredo Deza <[email protected]> (cherry picked from commit 4612ab3) (cherry picked from commit 7c63650)
Signed-off-by: Alfredo Deza <[email protected]> (cherry picked from commit 95b16b5) (cherry picked from commit bdf6a8b)
Signed-off-by: Alfredo Deza <[email protected]> (cherry picked from commit bfb8422) (cherry picked from commit 26b97ec)
This caused problems in environments where stderr was redirected, since stderr sets the encoding to None. Getting it back again allows everything to work correctly, and keeps all the current unit tests passing Signed-off-by: Alfredo Deza <[email protected]> (cherry picked from commit fe66e01) (cherry picked from commit d1615c0)
Signed-off-by: Alfredo Deza <[email protected]> (cherry picked from commit ee18ebc) (cherry picked from commit cd82ab7)
Signed-off-by: Alfredo Deza <[email protected]> (cherry picked from commit 595e492) (cherry picked from commit 1c2894d)
Signed-off-by: Alfredo Deza <[email protected]> (cherry picked from commit 7919635) (cherry picked from commit 4183d29)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as requested by @jan--f
Fixes: SUSE/DeepSea#1747