Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: disable `defer_client_eviction_on_laggy_osds' by default #515

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

mgfritch
Copy link

This config can result in a single client holding up mds to service other clients since once a client is deferred from eviction due to laggy OSD(s), a new clients cap acquire request can be possibly blocked until the other laggy client resumes operation, i.e., when the laggy OSD is considered non-laggy anymore.

Disable the config by default till the issue is fixed.

Fixes: http://tracker.ceph.com/issues/64685

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

Copy link

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would prefer it as git cherry-pick -x 109de8bdab86e1adaad580d9e7322c18fa01bc09 so we have information in git history that this is not SUSE specific.

@mgfritch
Copy link
Author

mgfritch commented Mar 17, 2024

nit: I would prefer it as git cherry-pick -x 109de8bdab86e1adaad580d9e7322c18fa01bc09 so we have information in git history that this is not SUSE specific.

I had to re-implement the fix, because the patch doesn't apply to pacific branch, but I've added the cherry-pick message to the commit anyway

@trociny
Copy link

trociny commented Mar 18, 2024

I had to re-implement the fix, because the patch doesn't apply to pacific branch, but I've added the cherry-pick message to the commit anyway

I see. The upstream approach in this situation is still to cherry-pick, resolve the conflict manually and add a note about the conflict to the log message. Anyway, LGTM, thanks.

This config can result in a single client holding up mds to service
other clients since once a client is deferred from eviction due to
laggy OSD(s), a new clients cap acquire request can be possibly
blocked until the other laggy client resumes operation, i.e., when
the laggy OSD is considered non-laggy anymore.

Disable the config by default till the issue is fixed.

Fixes: http://tracker.ceph.com/issues/64685
Signed-off-by: Venky Shankar <[email protected]>
(cherry picked from commit 109de8b)

Conflicts:
	src/common/options/mds.yaml.in
@mgfritch mgfritch merged commit bb20a17 into ses7p Mar 18, 2024
2 checks passed
@mgfritch mgfritch deleted the upstream-tracker-64685 branch March 18, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants