projects.py: Do not error on delete if force is True #141
Conversation
Signed-off-by: Marcos Paulo de Souza <[email protected]>
| if response.status_code == 404 and force: | ||
| return True |
There was a problem hiding this comment.
Hi there,
deletion by force is a feature of the OBS API:
Set to
1if you want to delete the project even if the repositories of other projects include a path to this project.
Without knowing your use case I would argue, that the deletion of a non-existing project (forcefully or otherwise) warrants to return the objectified error message.
Speaking of error messages: If the status code of the response were 404, your if block would not get executed, because self.osc.request will raise a HTTPError.
Would you like to discuss options?
There was a problem hiding this comment.
That's true... my use case is to just ignore if the project doesn't exist when force is specified but forgot about the exception...
I'm already handling the HTTPError in my project, but I was expecting of force argument to ignore non-existent projects... either way, we can drop this patch if you think the library user should take care of it :)
There was a problem hiding this comment.
Thank you for the description of your use case 🙂
Your use case makes sense to me, but I can also imagine that for other use cases, where OBS's force deletion is required, the exact error message might be relevant.
If it's OK with you, I'd suggest to handle the case of non-existing projects in your code instead of the library.
There was a problem hiding this comment.
Ok, makes sense. Thanks!
No description provided.