Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new prediction function that does not return the error/variance #49

Merged
merged 9 commits into from
Aug 12, 2024

Conversation

MatthieuSchaller
Copy link
Member

@MatthieuSchaller MatthieuSchaller commented Aug 10, 2024

Changes:

  • Implement Optionally skip returning the variance #48 by extending the class with a new method returning just the values without the associated error.
  • Applied formatting script.
  • Added missing elements in the docstrings of the predict_values() method of some of the instances.
  • Expanded documentation.

… tuple[np.array, np.array] from np.array. Applied formatting script
…ovide predictions without the associated errors, which can be a lot faster.
@JBorrow
Copy link
Member

JBorrow commented Aug 12, 2024

Looks good, just checking before we merge that this actually produces a performance improvement in your application?

@MatthieuSchaller
Copy link
Member Author

It's a 50x speed-up for my application!

@JBorrow JBorrow merged commit 81372fc into main Aug 12, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants