Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metallicity data from Chartab+23, Sanders+23, Pharo+23 #269

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Add metallicity data from Chartab+23, Sanders+23, Pharo+23 #269

merged 4 commits into from
Mar 21, 2024

Conversation

robjmcgibbon
Copy link
Collaborator

@robjmcgibbon robjmcgibbon commented Dec 15, 2023 •
edited
Loading

I will update the submodule link once https://github.com/SWIFTSIM/velociraptor-comparison-data/pull/189 is merged

@robjmcgibbon
Copy link
Collaborator Author

@EvgeniiChaikin I've updated the submodule link

EvgeniiChaikin
EvgeniiChaikin approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@EvgeniiChaikin EvgeniiChaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks perfect!

I also updated the year of the file of Driver's GSMF; this change was recently made in the obs. data repository but I haven't propagated it here.

@robjmcgibbon robjmcgibbon merged commit 723fe58 into master Mar 21, 2024
1 check passed
@robjmcgibbon robjmcgibbon deleted the add_metallicity_Chartab_Sanders_Pharo branch March 21, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvgeniiChaikin EvgeniiChaikin EvgeniiChaikin approved these changes

Assignees

@EvgeniiChaikin EvgeniiChaikin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robjmcgibbon @EvgeniiChaikin