-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add three plots with stellar birth temperatures #271
Conversation
…ml, as it now contains fields with temperature
Note that this PR follows SWIFTSIM/velociraptor-python#106 |
5e015d3
to
0a7fba1
Compare
I just pushed a minor change to address this comment by Joop |
@robjmcgibbon I have added plots showing stellar birth pressures. This update follows SWIFTSIM/SOAP#62 and SWIFTSIM/velociraptor-python#107 Now for all stellar birth properties -- density, temperature, and pressure -- we plot
These are plotted vs. stellar mass. I removed the plots vs. halo mass because otherwise we would have way too many plots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but could you please post a link with the new plots? I'm curious to see how the median compares with log-of-average
Sure! Here is an example of a webpage that has the new plots: https://swift.dur.ac.uk/COLIBREPlots/chaikin/individual_runs/YEAR2023/z0.0_L25N188_test_birth_properties_Jan19/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks, looks like it's pretty similar to log-of-average
Example here: https://swift.dur.ac.uk/COLIBREPlots/chaikin/comparisons/YEAR2023/z0.0_L25N376_weak_SN_and_AGN_feedback/index.html