Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add three plots with stellar birth temperatures #271

Merged
merged 6 commits into from
Jan 19, 2024

Conversation

EvgeniiChaikin
Copy link
Collaborator

@EvgeniiChaikin
Copy link
Collaborator Author

Note that this PR follows SWIFTSIM/velociraptor-python#106

colibre/registration.py Outdated Show resolved Hide resolved
colibre/registration.py Outdated Show resolved Hide resolved
@EvgeniiChaikin EvgeniiChaikin force-pushed the add_stellar_birth_temperature_plots branch from 5e015d3 to 0a7fba1 Compare January 12, 2024 15:53
@robjmcgibbon
Copy link
Collaborator

I just pushed a minor change to address this comment by Joop

@EvgeniiChaikin
Copy link
Collaborator Author

@robjmcgibbon I have added plots showing stellar birth pressures. This update follows SWIFTSIM/SOAP#62 and SWIFTSIM/velociraptor-python#107

Now for all stellar birth properties -- density, temperature, and pressure -- we plot

  • the minimum value
  • the maximum value
  • the median value

These are plotted vs. stellar mass. I removed the plots vs. halo mass because otherwise we would have way too many plots.

Copy link
Collaborator

@robjmcgibbon robjmcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but could you please post a link with the new plots? I'm curious to see how the median compares with log-of-average

@EvgeniiChaikin
Copy link
Collaborator Author

Copy link
Collaborator

@robjmcgibbon robjmcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks, looks like it's pretty similar to log-of-average

@robjmcgibbon robjmcgibbon merged commit 30c7d7d into master Jan 19, 2024
1 check passed
@robjmcgibbon robjmcgibbon deleted the add_stellar_birth_temperature_plots branch January 19, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants