Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two new plots with the information on the SN energy fractions #283

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

EvgeniiChaikin
Copy link
Collaborator

  • Add a plot that shows the relation between the SN energy fraction and stellar birth pressure
  • Add a plot that shows the relation between the SN energy fraction and galaxy stellar mass
  • Rewrite the code in the script that computes the distribution of SN energy fractions, to make it more readable and maintainable

Example:

Screenshot from 2024-06-03 16-29-37

The two plots on the right are the new plots.

- Add a plot that show the relation between the SN energy fraction and stlelar birth pressure
- Add a plot that show the relation between the SN energy fraction and galaxy stellar mass
- Rewrite the code in the script that computes the distribution of SN energy fractions, to make it more readable and maintainable
Copy link
Collaborator

@robjmcgibbon robjmcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I was able to run it with no issues. I don't like the fact that we repeat functions so often (e.g. energy_fraction in the PR), but I don't know a nice way around that with the current pipeline

@EvgeniiChaikin EvgeniiChaikin merged commit 49eee8a into master Jun 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants