Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Efficient iteration over SWIFTGalaxy objects #14

Merged
merged 99 commits into from
Oct 18, 2024
Merged

Efficient iteration over SWIFTGalaxy objects #14

merged 99 commits into from
Oct 18, 2024

Commits on Sep 16, 2024

  1. Initial sketched iteration implementation.

    @kyleaoman
    kyleaoman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    09464b2 View commit details
    Browse the repository at this point in the history

  2. Adjust typing.

    @kyleaoman
    kyleaoman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4c497bc View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Update gitignore.

    @kyleaoman
    kyleaoman committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2964598 View commit details
    Browse the repository at this point in the history

  2. Handle sharing coordinate frame in iteration.

    @kyleaoman
    kyleaoman committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    de4d96a View commit details
    Browse the repository at this point in the history

  3. Draft implementation of one iteration optimization scheme.

    @kyleaoman
    kyleaoman committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    48fd835 View commit details
    Browse the repository at this point in the history

  4. Commit before moving server out of loop.

    @kyleaoman
    kyleaoman committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    1e1c1ab View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Move server out of loop, start testing (bug apparent).

    @kyleaoman
    kyleaoman committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2d2bdb1 View commit details
    Browse the repository at this point in the history

  2. Add sparse optimization scheme and make sure tests run.

    @kyleaoman
    kyleaoman committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fb5adae View commit details
    Browse the repository at this point in the history

  3. Support custom spatial offsets, tested with/without by visualising.

    @kyleaoman
    kyleaoman committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    407b477 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Merge branch 'main' into iterator

    @kyleaoman
    kyleaoman committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    bba48fd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into iterator

    @kyleaoman
    kyleaoman committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c9fe811 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into iterator

    @kyleaoman
    kyleaoman committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9c0401a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into iterator

    @kyleaoman
    kyleaoman committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b9d4a16 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Update colibre quickstart guide for latest changes in codes.

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7859c85 View commit details
    Browse the repository at this point in the history

  2. Enable spatial_only=False masking now that ssio support it.

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2e9e477 View commit details
    Browse the repository at this point in the history

  3. Use the solution.

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5b9393d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into iterator

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4c8c813 View commit details
    Browse the repository at this point in the history

  5. Allow specifying preload info from halo_finder.

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    80e9674 View commit details
    Browse the repository at this point in the history

  6. Squash bug in sparse solution.

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    17b2923 View commit details
    Browse the repository at this point in the history

  7. Tidy up example after bugfixes.

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    81f69ac View commit details
    Browse the repository at this point in the history

  8. Mention order of iteration in example.

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e15a722 View commit details
    Browse the repository at this point in the history

  9. Upgrade test halo catalogues to 2 objets.

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1d7685a View commit details
    Browse the repository at this point in the history

  10. Sketch in commented-out abstractmethods.

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    db73b9d View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into iterator

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    42122d7 View commit details
    Browse the repository at this point in the history

  12. Remove restriction on numpy version.

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    10fdb57 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into iterator

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    cbe6c44 View commit details
    Browse the repository at this point in the history

  14. Rename halo_index to soap_index.

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    998054c View commit details
    Browse the repository at this point in the history

  15. Some preparations to extend multi-target to other HFs.

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    61e0547 View commit details
    Browse the repository at this point in the history

  16. Linting fixes.

    @kyleaoman
    kyleaoman committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3de7137 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Move more functionality to base class.

    @kyleaoman
    kyleaoman committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    a996712 View commit details
    Browse the repository at this point in the history

  2. Ensure linting passes.

    @kyleaoman
    kyleaoman committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    5b5ed35 View commit details
    Browse the repository at this point in the history

  3. Tidy up comments and leftover child class functions.

    @kyleaoman
    kyleaoman committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    3430d17 View commit details
    Browse the repository at this point in the history

  4. More tidying and fix failing test.

    @kyleaoman
    kyleaoman committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    5c4a2f7 View commit details
    Browse the repository at this point in the history

  5. Add region helpers to velociraptor class.

    @kyleaoman
    kyleaoman committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    5d66854 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Sketch in the rest of the Caesar class for multi-galaxy usage.

    @kyleaoman
    kyleaoman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    085ca48 View commit details
    Browse the repository at this point in the history

  2. Finish drafting multi-galaxy support for all classes.

    @kyleaoman
    kyleaoman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    206c30d View commit details
    Browse the repository at this point in the history

  3. Set up tests for multi-galaxy catalogue and iterator creation.

    @kyleaoman
    kyleaoman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    76529d2 View commit details
    Browse the repository at this point in the history

  4. Fix bugs in tests.

    @kyleaoman
    kyleaoman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    493f7cf View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Bugfixes so that we can create all multi-halo catalogues.

    @kyleaoman
    kyleaoman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    13308ed View commit details
    Browse the repository at this point in the history

  2. And for standalone.

    @kyleaoman
    kyleaoman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2ef554a View commit details
    Browse the repository at this point in the history

  3. Fixes to pass linting.

    @kyleaoman
    kyleaoman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    431976f View commit details
    Browse the repository at this point in the history

  4. Add missing units.

    @kyleaoman
    kyleaoman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c64da7e View commit details
    Browse the repository at this point in the history

  5. Start adding tests for multi-galaxy halo finder mode.

    @kyleaoman
    kyleaoman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5836241 View commit details
    Browse the repository at this point in the history

  6. Pencil in a few more tests.

    @kyleaoman
    kyleaoman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a065039 View commit details
    Browse the repository at this point in the history

  7. More bugfixes from testing.

    @kyleaoman
    kyleaoman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a12c7c5 View commit details
    Browse the repository at this point in the history

  8. Add test for spatial masking in multi-mode.

    @kyleaoman
    kyleaoman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    859dbe3 View commit details
    Browse the repository at this point in the history

  9. Add tests for bound only masking.

    @kyleaoman
    kyleaoman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d399a26 View commit details
    Browse the repository at this point in the history

  10. Add masking index list and tests thereof.

    @kyleaoman
    kyleaoman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b8a248e View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Continue adding tests.

    @kyleaoman
    kyleaoman committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    daf5949 View commit details
    Browse the repository at this point in the history

  2. Fix a type hint.

    @kyleaoman
    kyleaoman committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    fd6a8a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Complete tests for iterator.

    @kyleaoman
    kyleaoman committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6b369c1 View commit details
    Browse the repository at this point in the history

  2. Fix typo in test.

    @kyleaoman
    kyleaoman committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    098a71a View commit details
    Browse the repository at this point in the history

  3. Start turning on docstring linting.

    @kyleaoman
    kyleaoman committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2a9e962 View commit details
    Browse the repository at this point in the history

  4. Some fixes to docstrings from linting.

    @kyleaoman
    kyleaoman committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    70a0c49 View commit details
    Browse the repository at this point in the history

  5. Finish linting existing docstrings.

    @kyleaoman
    kyleaoman committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c45db06 View commit details
    Browse the repository at this point in the history

  6. Enable linting missing docstrings.

    @kyleaoman
    kyleaoman committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    539bf06 View commit details
    Browse the repository at this point in the history

  7. Tidy up existing docstrings.

    @kyleaoman
    kyleaoman committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9ba44bb View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Split copy constructor into a (private) classmethod.

    @kyleaoman
    kyleaoman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d721d6a View commit details
    Browse the repository at this point in the history

  2. Call init on class (not instance) and tidy up.

    @kyleaoman
    kyleaoman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ca49bc7 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Write in many more docstrings.

    @kyleaoman
    kyleaoman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    54b3d38 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Add more docstrings.

    @kyleaoman
    kyleaoman committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b492e17 View commit details
    Browse the repository at this point in the history

  2. Write more docstrings.

    @kyleaoman
    kyleaoman committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    daf2ce9 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Fill in some more docstrings.

    @kyleaoman
    kyleaoman committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b229e5c View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Finish docstrings for halo_catalogues module.

    @kyleaoman
    kyleaoman committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    4fcd95f View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Restructure for consistent type hinting.

    @kyleaoman
    kyleaoman committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    17bd118 View commit details
    Browse the repository at this point in the history

  2. Fill out examples for SWIFTGalaxies.

    @kyleaoman
    kyleaoman committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    fe30ff3 View commit details
    Browse the repository at this point in the history

  3. Add docstring linting to CI.

    @kyleaoman
    kyleaoman committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    aa4d55d View commit details
    Browse the repository at this point in the history

  4. Replace tabs with spaces.

    @kyleaoman
    kyleaoman committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    b423a78 View commit details
    Browse the repository at this point in the history

  5. Add iterator to API docs, fix some docs bugs.

    @kyleaoman
    kyleaoman committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    53a3764 View commit details
    Browse the repository at this point in the history

  6. Rough in page for iterating docs.

    @kyleaoman
    kyleaoman committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    8df78f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Add warning when reading data that should probably be preloaded.

    @kyleaoman
    kyleaoman committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    bc2c452 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Add iterator module to mypy coverage.

    @kyleaoman
    kyleaoman committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    6a27927 View commit details
    Browse the repository at this point in the history

  2. Changes to support map working.

    @kyleaoman
    kyleaoman committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8b9a99b View commit details
    Browse the repository at this point in the history

  3. Tidy up warnings in testing.

    @kyleaoman
    kyleaoman committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e148dc2 View commit details
    Browse the repository at this point in the history

  4. Split catalogue and index masks in multi-galaxy mode.

    @kyleaoman
    kyleaoman committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7ddd77f View commit details
    Browse the repository at this point in the history

  5. Add a test of args/kwargs passed to map.

    @kyleaoman
    kyleaoman committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    63d3b44 View commit details
    Browse the repository at this point in the history

  6. Tidy up docstrings.

    @kyleaoman
    kyleaoman committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    cf87644 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Add test isolating SOAP catalogue ordering issue.

    @kyleaoman
    kyleaoman committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8b22391 View commit details
    Browse the repository at this point in the history

  2. Cover more catalogue attributes in soap ordering test.

    @kyleaoman
    kyleaoman committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c3087ee View commit details
    Browse the repository at this point in the history

  3. Use correct index in masking (mainly for soap).

    @kyleaoman
    kyleaoman committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    973ce95 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Use correct mask on index in soap (need to swap names).

    @kyleaoman
    kyleaoman committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    baa5b58 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Insert at correct location in map.

    @kyleaoman
    kyleaoman committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    0290615 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Add test for non-matching multi/single catalogue items seen in soap.

    @kyleaoman
    kyleaoman committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    efacfdf View commit details
    Browse the repository at this point in the history

  2. Mask with slice instead of int in soap to match single-mode.

    @kyleaoman
    kyleaoman committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    3fdadd9 View commit details
    Browse the repository at this point in the history

  3. Amend tests for slice mask for soap catalogue.

    @kyleaoman
    kyleaoman committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    f3cddc9 View commit details
    Browse the repository at this point in the history

  4. Print particle dataset (and namedcolumn name) in warnings.

    @kyleaoman
    kyleaoman committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    1b2dda8 View commit details
    Browse the repository at this point in the history

  5. Start working on accepting arrays and unyt arrays as index lists.

    @kyleaoman
    kyleaoman committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    8c8b185 View commit details
    Browse the repository at this point in the history

  6. Allow arrays and unyt_arrays as index lists.

    @kyleaoman
    kyleaoman committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    aa276a3 View commit details
    Browse the repository at this point in the history

  7. Remove unused imports.

    @kyleaoman
    kyleaoman committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    8ab7e89 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Update map to allows different args/kwargs on each iteration.

    @kyleaoman
    kyleaoman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e89f378 View commit details
    Browse the repository at this point in the history

  2. Update cookbook examples for Colibre on cosma.

    @kyleaoman
    kyleaoman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    13d86e5 View commit details
    Browse the repository at this point in the history

  3. Fix mypy issues.

    @kyleaoman
    kyleaoman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    cfc8cfa View commit details
    Browse the repository at this point in the history

  4. Remove accidentally added quicktest.py file.

    @kyleaoman
    kyleaoman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a3349d0 View commit details
    Browse the repository at this point in the history

  5. Bump version in preparation for release.

    @kyleaoman
    kyleaoman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    fe34d6d View commit details
    Browse the repository at this point in the history

  6. Fix formatting in docs for map.

    @kyleaoman
    kyleaoman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    53a695f View commit details
    Browse the repository at this point in the history

  7. Get args and kwargs in right order in map.

    @kyleaoman
    kyleaoman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d9c2b46 View commit details
    Browse the repository at this point in the history

  8. Get the args order right in map...

    @kyleaoman
    kyleaoman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a91f50b View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Fill in narrative docs for SWIFTGalaxies.

    @kyleaoman
    kyleaoman committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3cf32d7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into iterator

    @kyleaoman
    kyleaoman committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9001630 View commit details
    Browse the repository at this point in the history