Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial power spec version #186

Merged
merged 31 commits into from
Jun 20, 2024
Merged

Added initial power spec version #186

merged 31 commits into from
Jun 20, 2024

Conversation

JBorrow
Copy link
Member

@JBorrow JBorrow commented Mar 12, 2024

I don't understand why this isn't working. This version has significant dependences on the number of pixels used for voxelization of the underlying particle data, and as a function of folding:

dark_matter_power_spectrum

This plot is made with cosmo_volume_example.hdf5 that we have hosted on IOExamples.

@JBorrow
Copy link
Member Author

JBorrow commented Mar 14, 2024

So I took a mesh from nbodykit, and tried to run it through our power spectrum code:

Nbodykit:

Screenshot 2024-03-14 at 2 07 00 PM

Ours:

dark_matter_power_spectrum_mesh_from_nbodykit

@JBorrow
Copy link
Member Author

JBorrow commented Mar 14, 2024

Ok, I got them to overlap more with the current code version...
dark_matter_power_spectrum_mesh_from_nbodykit

@JBorrow
Copy link
Member Author

JBorrow commented Mar 14, 2024

dark_matter_power_spectrum

About a factor of 1e6 off but this looks a bit better

@JBorrow
Copy link
Member Author

JBorrow commented Mar 15, 2024

Working!

dark_matter_power_spectrum

@JBorrow
Copy link
Member Author

JBorrow commented Apr 2, 2024

Aside from not handling shot noise correctly, we are looking very good w.r.t. SWIFT!

spectra_comparison

@JBorrow
Copy link
Member Author

JBorrow commented Apr 23, 2024

Now added docs and the auto-fold version.

dark_matter_power_spectrum

Power Spectra — SWIFTsimIO 7.0.3 documentation.pdf

@JBorrow
Copy link
Member Author

JBorrow commented Jun 11, 2024

Auto-folding is now in the codebase, and allows for better transitions between folds (seems our averaging scheme doesn't really work):

power_spectrum

power_spectrum

@JBorrow
Copy link
Member Author

JBorrow commented Jun 12, 2024

power_spectrum
Fixed divots. Happy to merge.

@JBorrow JBorrow marked this pull request as ready for review June 12, 2024 14:38
@JBorrow JBorrow merged commit 843b349 into master Jun 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant