Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

fix: style math blocks appropriately #138

Merged
merged 4 commits into from
Jul 22, 2021
Merged

fix: style math blocks appropriately #138

merged 4 commits into from
Jul 22, 2021

Conversation

lars-reimann
Copy link
Member

Closes #131.

Summary of Changes

Previously only inline math formulae where rendered properly. This was now extended to block formulae as well.

Screenshots (if necessary)

The comparison was made for sklearn / sklearn.metrics._classification / cohen_kappa_score.

Before

image

After

image

Testing instructions

Ensure block formulae are rendered as expected (as long as the LaTeX in the documentation of scikit-learn is correct):

  1. Search for .. math:: in the JSON to find such cases.
  2. Compare with the scikit-learn documentation, e.g. for sklearn.metrics.cohen_kappa_score.

Copy link
Contributor

@paul0314 paul0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image

Wie in diesem Beispiel zu sehen (sklearn/sklearn._loss.glm_distribution/ExponentialDispersionModel) werden math blocks durch die Regex noch nicht vollständig richtig vorverarbeitet.

@paul0314 paul0314 merged commit 71ccf7b into master Jul 22, 2021
@paul0314 paul0314 deleted the block_math branch July 22, 2021 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Math Formeln richtig formattiert darstellen
2 participants