Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

feat: Automatic generation of Required Annotations #452

Merged

Conversation

GideonKoenig
Copy link
Contributor

Closes #442.

Summary of Changes

Add automated generation of required annotations.

@GideonKoenig GideonKoenig linked an issue Apr 29, 2022 that may be closed by this pull request
GideonKoenig added 2 commits April 29, 2022 11:51
…rleitung-von-required-annotations

# Conflicts:
#	package-parser/package-parser.iml
#	package-parser/package_parser/commands/generate_annotations/generate_annotations.py
#	package-parser/tests/commands/generate_annotations/test_generate_annotations.py
@jofaul
Copy link
Contributor

jofaul commented Apr 29, 2022

WO SIND DIE TESTS

1 similar comment
@jofaul
Copy link
Contributor

jofaul commented Apr 29, 2022

WO SIND DIE TESTS

@github-actions
Copy link

github-actions bot commented Apr 29, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 3.96s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 2 0 0 1.23s
✅ JSON jsonlint 2 0 0.58s
✅ JSON prettier 2 0 0 0.72s
✅ JSON v8r 2 0 2.13s
✅ PYTHON black 3 0 0 0.57s
✅ PYTHON isort 3 0 0 0.17s
✅ PYTHON mypy 3 0 24.56s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@jofaul jofaul requested review from jofaul April 29, 2022 10:53
@lars-reimann
Copy link
Member

lars-reimann commented Apr 29, 2022

Statt des Labels "DO NOT MERGE" oder zusätzlich dazu lassen sich Pull Requests auch als Entwurf markieren:

image

Das verhindert versehentliches Mergen.

GideonKoenig and others added 8 commits April 29, 2022 16:06
… of github.com:lars-reimann/api-editor into 442-automatisierte-herleitung-von-required-annotations
Improved auxiliary functions
Added ParameterInfo Class to communicate the return values of functions better
Migrated said ParameterInfo and ParameterType classes to annotation_model.py
Test is now working - all is good
@GideonKoenig
Copy link
Contributor Author

@lars-reimann Hier steht, dass es einen Konflikt in package-parser.iml gibt. Ich kann jedoch nicht erkennen, was hier das Problem ist.

@lars-reimann
Copy link
Member

lars-reimann commented Apr 30, 2022

Die Datei ist im Main gelöscht. In diesem Branch sollte sie ebenfalls nicht mehr vorhanden sein.

@github-actions
Copy link

github-actions bot commented May 6, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 4.28s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 2 0 0 1.48s
✅ JSON jsonlint 2 0 0.61s
✅ JSON prettier 2 0 0 0.74s
✅ JSON v8r 2 0 2.17s
✅ PYTHON black 3 0 0 0.6s
✅ PYTHON isort 3 0 0 0.24s
✅ PYTHON mypy 3 0 38.24s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

Copy link
Contributor

@jofaul jofaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht super aus!

@GideonKoenig
Copy link
Contributor Author

@lars-reimann Der pull request wäre ready dafür, dass du drübe guckst und ihm deinen approval gibst.

@lars-reimann lars-reimann merged commit b9031b5 into main May 6, 2022
@lars-reimann lars-reimann deleted the 442-automatisierte-herleitung-von-required-annotations branch May 6, 2022 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement 💡 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatisierte Herleitung von Required Annotations
3 participants