Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong detection of useless statements that call parameters/unknown callables #790

Merged
merged 10 commits into from
Nov 22, 2023
Merged

fix: wrong detection of useless statements that call parameters/unknown callables #790

merged 10 commits into from
Nov 22, 2023

Commits on Nov 22, 2023

  1. test: add tests to reproduce the issue

    @lars-reimann
    lars-reimann committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    bc672bd View commit details
    Browse the repository at this point in the history

  2. feat: allow parameters as values of EvaluatedCallable

    @lars-reimann
    lars-reimann committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    0ff5676 View commit details
    Browse the repository at this point in the history

  3. feat: track calls of parameters in call graphs

    @lars-reimann
    lars-reimann committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    d9ea84d View commit details
    Browse the repository at this point in the history

  4. feat: add unknown callable call as (inferred) impurity reason

    @lars-reimann
    lars-reimann committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    be29428 View commit details
    Browse the repository at this point in the history

  5. fix: include calls of unknown callables or potentially impure paramet… 

    …ers as impurity reason
    @lars-reimann
    lars-reimann committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    a781a4a View commit details
    Browse the repository at this point in the history

  6. test: get impurity reasons if a called callable is unknown

    @lars-reimann
    lars-reimann committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    738ab4b View commit details
    Browse the repository at this point in the history

  7. test: get impurity reasons if a called parameter is potentially impure

    @lars-reimann
    lars-reimann committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    215ff12 View commit details
    Browse the repository at this point in the history

  8. test: get impurity reasons if a called parameter is known pure

    @lars-reimann
    lars-reimann committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    f4f8e60 View commit details
    Browse the repository at this point in the history

  9. feat: get all tests working

    @lars-reimann
    lars-reimann committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    da2146e View commit details
    Browse the repository at this point in the history

  10. test: unit tests for isPureParameter

    @lars-reimann
    lars-reimann committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    0f4179a View commit details
    Browse the repository at this point in the history