fix: handling of default values in entry point of call graph computation #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 86 86
Lines 13497 13505 +8
Branches 2855 2860 +5
=========================================
+ Hits 13497 13505 +8 ☔ View full report in Codecov by Sentry. |
lars-reimann
pushed a commit
that referenced
this pull request
Nov 25, 2023
## [0.5.0](v0.4.0...v0.5.0) (2023-11-25) ### Features * error if index of indexed access is invalid ([#796](#796)) ([5017759](5017759)), closes [#16](#16) * full implementation of partial evaluator ([#798](#798)) ([7643794](7643794)), closes [#603](#603) * settings to hide selected warnings/infos ([#795](#795)) ([ff7c23a](ff7c23a)), closes [#35](#35) ### Bug Fixes * handling of default values in entry point of call graph computation ([#797](#797)) ([a5db23c](a5db23c))
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Consider the following code:
When computing the call graph for the
param()call, we were previously always substitutingparamwith its default value, since the parameter substitutions were empty in the entry point. Because of this, we were incorrectly considering theparam()call as pure, just like the segmentmySegment.