Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make _Layer public #691

Closed
lars-reimann opened this issue May 2, 2024 · 1 comment · Fixed by #692
Closed

Make _Layer public #691

lars-reimann opened this issue May 2, 2024 · 1 comment · Fixed by #692
Assignees
@lars-reimann
Labels
released Included in a release

Comments

@lars-reimann
Copy link
Member

Classes (e.g. ForwardLayer) should not inherit from internal classes. The solution in this case is to make _Layer public again. This is consistent with Classifier, Regressor, ...
@github-project-automation github-project-automation bot moved this to Backlog in Library May 2, 2024
@lars-reimann lars-reimann self-assigned this May 2, 2024
@lars-reimann lars-reimann moved this from Backlog to Todo in Library May 2, 2024
@lars-reimann lars-reimann mentioned this issue May 2, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to ✔️ Done in Library May 2, 2024
lars-reimann pushed a commit that referenced this issue May 2, 2024
@semantic-release-bot
chore(release): 0.22.1 [skip ci]
69736a3 
## [0.22.1](v0.22.0...v0.22.1) (2024-05-02)

### Bug Fixes

* make `_Layer`, `_InputConversion`, `_OutputConversion` public ([#692](#692)) ([eb226f4](eb226f4)), closes [#690](#690) [#691](#691)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make _Layer, _InputConversion, _OutputConversion public Safe-DS/Library
1 participant
@lars-reimann