feat: Add custom OutOfBoundsError and replace existing ValueErrors
#303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
co-authored-by: daniaHu <[email protected]>
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## main #303 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 43
Lines 1761 1794 +33
=========================================
+ Hits 1761 1794 +33
|
| """Exception raised when a value is not in the range [lower, upper].""" | ||
|
|
||
| def __init__(self, value: float, lower: float, upper: float) -> None: | ||
| super().__init__(f"Value {value} is not in the range [{lower}, {upper}].") |
There was a problem hiding this comment.
adjust the message for the boundaries of _table line 978-981.
alex-senger
commented
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262.
Summary of Changes
Add custom
OutOfBoundsErrorand replace existingValueErrorsthat need to be more specific.